starfish
starfish copied to clipboard
feat(filter): filter repositories by IGNORE_REPOSITORIES and GITHUB_ORGANIZATIONS
Fixed Issue #66
@danisyellis hope to find you well! would that be your need? if yes, could you approve the PR? I'm contributing to the hacktoberfest, if you can tag the PR I'd appreciate it too
Thanks for your contribution @jacksjm! At a first glance, this looks like it will do what we're looking for. I'll take a more thorough look and do some code review soon. (And I'll make sure to tag it for Hacktoberfest once it's approved :-)
Thanks a lot @danisyellis and waiting feedback :D
Here's my code review (finally, I know.)
A lot of it is small naming changes, but there are also some functionality issues that need to be fixed. I'm going to mark your PR as Hacktoberfest accepted to make sure you get credit since it's my fault the review is coming so late, but I'd still love it if you could make the changes :-)
Let me know if you have any questions about my comments.
Off course! I'm very glad to proceed with these fixes... now I'm little busy, but soon I work on this
@jacksjm : Thanks for submitting your updates. Dani isn't available to review them right now, but will do so as soon as possible.