make_absolute_paths don't depend anymore on STATIC_URL

[dvl]

Attempt to fix #103

[johnraz]

@dvl thanks for the contrib, can you make sure tests are passing before I start reviewing this? Thanks !

[johnraz]

@dvl friendly ping regarding this PR :-)

[dvl]

@johnraz sorry for late response, I'm was not using wkhtmltopdf for a while.

I've updated tests for when templates use static files but I'm not sure on how to deal with media files because static finders don't search for uploaded files.

Any thoughts?

[axerdan]

You can resolve MEDIA_URL url using a simple os.path.join.

https://github.com/incuna/django-wkhtmltopdf/pull/126/commits/9cdb5731017f24d119d8403c0b220f42412bd348#diff-36b0c981b229128ec810acc97c68d8feR247

This row should be something like this (not tested):

if occur.startswith(settings.STATIC_URL):
    pathname = finders.find(filename, all=False)
else:
    pathname = os.path.join(settings.MEDIA_ROOT, filename)

This patch could resolve a lot of problems with rendering templates using static/media urls!

[fixmycode]

any chance those changes be merged? the tests failed because of a connection error.

[johnraz]

@fixmycode there are also conflict to resolve first.

[fixmycode]

@johnraz can I fix them? should I make a new PR?

[johnraz]

Sure go with a new PR

[fixmycode]

@dvl if you merge the new master (d31e839) tests should be working now

[dvl]

I've updated the master but I'd like to implement @Keeper82 idea to deal with media files