PuzzleScript icon indicating copy to clipboard operation
PuzzleScript copied to clipboard

Inconsistent behaviour on compile with errors

Open david-pfx opened this issue 1 year ago • 0 comments

MAX_ERRORS is set to 5 in compiler.js. If this limit is hit the compiler emits a console message and exits.

The HTML system error message 'Errors detected during compilation' is then not hit, so there is no error message during export. A bad export will fail silently.

MAX_ERRORS_FOR_REAL is set to 100 in parser.js, so the function TooManyErrors() and its message is never hit.

Suggested fix: remove MAX_ERRORS and any tests using it.

david-pfx avatar Apr 23 '23 04:04 david-pfx