PuzzleScript icon indicating copy to clipboard operation
PuzzleScript copied to clipboard

Cannot build compile.js

Open david-pfx opened this issue 1 year ago • 1 comments

New clone of PuzzleScript, then

>npm i rimraf@3 compress-images web-resource-inliner ncp [email protected] concat ycssmin terser gzipper html-minifier-terser glob   
>node .\compile.js

Usual console messages down to here:

Optimizing documentation gifs
TypeError: glob is not a function
TypeError: glob is not a function
<Dumps a bunch of text then:>
RuntimeError: abort(TypeError: glob is not a function). Build with -s ASSERTIONS=1 for more info.
    at process.abort (D:\MyDocs\dev\Polyomino\PSForks\(increpare)PuzzleScript\node_modules\@gfx\zopfli\dist\libzopfli.js:1:11690)
    at process.emit (node:events:513:28)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)

I'm sure this used to work, but not now. [With rimraf@4 the error is Illegal characters in path, due to breaking change in rimraf.]

david-pfx avatar Apr 20 '23 10:04 david-pfx

Basically the same issue as the previous issues you've had with compile.js - the glob package released version 10 recently and it changed its interface. You'll want to pin glob to version 9. Your PR #956 will already fix this.

(Edit: It turned out actually glob 9 also broke things - so glob 8 is the correct version)

sftrabbit avatar Apr 20 '23 17:04 sftrabbit

I mention the right version now in https://github.com/increpare/PuzzleScript/commit/4a025e4c18ef24de9fe326ff4fbaf27a6e6a9b69

increpare avatar Apr 26 '24 19:04 increpare