PuzzleScript icon indicating copy to clipboard operation
PuzzleScript copied to clipboard

Some chars in prelude tags are not escaped properly, and these can cause exported games to fail compilation

Open Auroriax opened this issue 2 years ago • 5 comments

e.g. if you give a game the title of a HTML tag, for example <script>, then you will be allowed to share export the game, but for the export, the generated file is not valid HTML5 and it will cause the HTML5 code to run into errors and the game to fail to load. It seems that some characters (the < and > brackets in this example, possibly more) are not always escaped properly.

Note that this only affects exported games and not share links.

Auroriax avatar Jul 20 '22 20:07 Auroriax

I suggest you supply an explicit repro case including a sample (tiny) game.

david-pfx avatar Mar 06 '23 09:03 david-pfx

it's ok, there's already a repro in the linked issue; i'm just lazy

increpare avatar Mar 06 '23 14:03 increpare

I thought I might have a look at it, but since I can't build the standalone right now I guess there isn't much point.

david-pfx avatar Mar 06 '23 22:03 david-pfx

I've had a look, I can fix it. But I don't see any easy way to test it.

My motto is: if you can't test it don't write it. Might have to make an exception for this one.

david-pfx avatar Mar 07 '23 06:03 david-pfx

Replaced by single purpose PR

david-pfx avatar Apr 24 '23 07:04 david-pfx