PuzzleScript
PuzzleScript copied to clipboard
Some chars in prelude tags are not escaped properly, and these can cause exported games to fail compilation
e.g. if you give a game the title of a HTML tag, for example <script>
, then you will be allowed to share export the game, but for the export, the generated file is not valid HTML5 and it will cause the HTML5 code to run into errors and the game to fail to load. It seems that some characters (the <
and >
brackets in this example, possibly more) are not always escaped properly.
Note that this only affects exported games and not share links.
I suggest you supply an explicit repro case including a sample (tiny) game.
it's ok, there's already a repro in the linked issue; i'm just lazy
I thought I might have a look at it, but since I can't build the standalone right now I guess there isn't much point.
I've had a look, I can fix it. But I don't see any easy way to test it.
My motto is: if you can't test it don't write it. Might have to make an exception for this one.
Replaced by single purpose PR