Alan Shreve

Correct, lazy only works for values. That’s probably something I should add to the documentation. On Sep 18, 2014, at 9:24 PM, Jack Chen [email protected] wrote: > Ah, I was...

Just like all buffered IO APIs wrap the IO interfaces and add a `Flush()` method: ``` go type BulkHandler interface { Handler Flush() error } ``` Applications can then determine...

Yeah, we need a way to make the formatter more customizable. I like the idea of setting up functional options for the LogFmtFormat constructor and letting you pass those in....

interesting. @kevinburke or I might take a stab at resurrecting that approach. do you like the way that worked out for `StdlibAdapterOption` in go-kit/log?

Sorry for the insanely slow turnaround here. LGTM. Do we have thoughts on the following: 1. Do we want to add a third-party dependency (or vendor it)? 2. Could it...

The bulk logging stuff is interesting, I'll comment on that in the separate issue you opened for it. I'm on board with log15/ext/loggly and the dependency on ffjson. Also, all...

LGTM. Last thing we need is just a test. We could set up an HTTP server in the test and then set up a loggly handler with a custom URL...

Agreed, I see no reason to send anything over than JSON. The format is irrelevant in this case because we're sending to a machine. The goal is no loss of...

Agreed. I'd prefer to use JsonFormat internally, if possible. Are we using the go generated JSON encoding just for speed, or is there another reason? Otherwise I'm fine with exposing...

This is what we were waiting on: "I've pushed a work in progress test, but it's not working.. Looks like a problem with the channel (might be a Go issue...