IncludeOS icon indicating copy to clipboard operation
IncludeOS copied to clipboard

microLB no longer builds with NaCl

Open AndreasAakesson opened this issue 5 years ago • 1 comments

The microLB constructor has changed multiple times on dev (related change: 612c86d), which makes NaCl outdated. From what I can see it's no longer possible to just change the one line constructing the object, since the option of either tcp, s2n or openssl. I'm not sure if this means the load balancer NaCl object also needs to extended or changed (@fwsGonzo and @AnnikaH maybe can see this).

It's also obvious either the OS test suite or NaCl needs to take responsible for making sure the microLB is actually built by NaCl to avoid changes like this going undiscovered.

AndreasAakesson avatar Feb 13 '19 11:02 AndreasAakesson

Did we solve this? By just making a constructor parameter have a default value, or something.

fwsGonzo avatar Jun 23 '19 09:06 fwsGonzo