Melissa Kilby

Results 548 comments of Melissa Kilby

Unit tests just needed to be updated w/ `set_lookup_status(sinsp_container_lookup::state::SUCCESSFUL)`.

Exactly @leogr there was never a milestone since it's not particularly urgent from a functionality point of view, but it's one step towards making sure we don't break the container...

Rebased so that the new container e2e tests can run.

> I don't think that we should go ahead with this PR. The recommendation right now is to not commit the resolved file in libraries since the file has no...

> Yeah, it is not useful to have a Package.resolved in libraries. > > Package.resolved isn't a real lock file; it doesn't matter at all in libraries either since consumer...

@Molter73 we usually have the habit to bump both libs and driver during the dev phase. Few times we didn't do it and it caused compatibility issues. If you agree...

/hold for possible patches https://github.com/falcosecurity/falco/issues/3271#issuecomment-2206918760. Do not merge prior to having made a decision.

Re unit tests: Curious to know where to add tests as for most configs we do not have any here except for example for `engine_modern_config.yaml` etc. And / or likely...