Melissa Kilby
Melissa Kilby
@mrgian hope all is well, just wanted to kindly check in and ask what our current plan is to get out of the regression in our scap platforms approach? (https://github.com/falcosecurity/falco/issues/2821)...
> Hey @incertum For now I'm just moving linux-specific metrics collection logic to the `scap_platform` vtable. So that we can use the scap handle to gather platform-dependent metrics. This will...
> If I'm not wrong, currently `libs_resource_utilization` (https://github.com/falcosecurity/libs/blob/master/userspace/libsinsp/metrics_collector.h#L271-L300) is the only class with linux-only code. Confirmed. > As you said, taking a decision on the directory naming will influence future...
/hold until https://github.com/falcosecurity/libs/pull/1652 is merged.
@federico-sysdig given the changes @FedeDP and @Molter73 made to the libs metrics collector, would you mind reviewing the current code in master again and let us know what changes would...
> @federico-sysdig given the changes @FedeDP and @Molter73 made to the libs metrics collector, would you mind reviewing the current code in master again and let us know what changes...
Big +1 from my side ❤️ Samuel has been helping us tremendously over the past ~7 months, most notably in the following areas: - Falco outputs - C++ coding standards...
We likely need a rebase for the CI to pass.
Not sure if it will merge, @LucaGuerra mind checking as I am offline now...