inception icon indicating copy to clipboard operation
inception copied to clipboard

#3611 - Upgrade to Spring 6, Boot 3, Wicket 10, etc.

Open reckart opened this issue 3 years ago • 2 comments

What's in the PR

  • Java 11 -> 17
  • spring 5.3.24 -> 6.0.9
  • spring-boot 2.7.5 -> 3.1.0
  • spring-data 2.7.5 -> 3.1.0
  • spring-security 5.7.5 -> 6.1.0
  • tomcat 9.0.69 -> 10.1.1
  • servlet-api 4.0.1 -> 6.0.0
  • hibernate 5.6.14 -> 6.2.4
  • hibernate-validator 6.2.5 -> 8.0.0
  • wicket 9.x -> 10.0.0-M1
  • wicketstuff 9.x -> 10.0.0-SNAPSHOT
  • wicket jquery 9.x -> 10.0.0-SNAPSHOT
  • wicket bootstrap 6.0.x -> 7.0.0-SNAPSHOT
  • wicket springboot 3.x -> 4.0.0-SNAPSHOT
  • Use Jakarta dependencies instead of old javax dependencies

Problems

  • [ ] FusekiRepositoryTest not working (probably need to wait for Jena 5 to reactivate those - https://lists.apache.org/[email protected]:2023-4:jena%205)
  • [ ] SolrSearchProviderTest not working (probably need to wait for Solr 10 to reactivate those - https://issues.apache.org/jira/browse/SOLR-16441, https://github.com/apache/solr/pull/1509)
  • [ ] All DB entities with a @Lob String need to be set to @Column(length = 16_777_216) to make current MySQL scheme validation pass because Hibernate now uses the length to determine the best column type (before @Lob was always LONGTEXT) - that is maybe not the best idea. Might need to migrate the DB to use other types. Need to check embedded DB as well.

How to test manually

  • No specific test procedure. Pervasive change, just try using the app.

Automatic testing

  • [ ] PR includes unit tests

Documentation

  • [ ] PR updates documentation

reckart avatar Dec 04 '22 10:12 reckart

Hi @reckart

Spring boot 3.0 and 3.1 use jetty 11x but Spring boot 3.2 will use jetty 12x.

Maybe it would be more interesting to upgrade directly to jetty 12x, what do you think? Or release two versions, one with 11x and one with 12x?

jorgerod avatar Nov 03 '23 11:11 jorgerod

INCEpTION does not use Jetty at all, it uses Tomcat. If Jetty is used, then only by third-party libraries for unit tests.

reckart avatar Nov 03 '23 11:11 reckart