circumflex icon indicating copy to clipboard operation
circumflex copied to clipboard

Replace ineffective String concat in dialect.scala

Open timowest opened this issue 12 years ago • 2 comments

dialect.scala features non-optimal String concatenation in

def select(q: Select[_]): String = { ...

Consider using StringBuilder for it.

timowest avatar Nov 04 '11 21:11 timowest

Yes, you are right. Actually, I am thinking of some kind of QueryFormatter helper, which holds a mutable StringBuilder instance inside and also capable of pretty-formatting queries. Hope I'll get my hands on this one someday :)

inca avatar Nov 06 '11 07:11 inca

Sounds like a good idea. Providing both single and multi-line serialization would be nice, I am not sure, if it's already there.

timowest avatar Nov 06 '11 09:11 timowest