system-overlay-window again on 6.0.1

[erikswed]

And Android 6.0.1 api23 When I add this

compile 'com.github.inaka:galgo:v1.0.2'

The app crash with:

Caused by: java.lang.IllegalStateException: in order to use Galgo, please add the permission android.permission.SYSTEM_ALERT_WINDOW to your AndroidManifest.xml.

Even do I have this perrmission and also it´s included in galgo lib right

I cannot figure out this please advice?

I read that I should test for this permission since I side-lode the apk

https://stackoverflow.com/questions/32652533/android-system-overlay-window

but app crash before Activity onCreate

[SaikCaskey]

also seeing on 6.0.1 and 7.1.2, but not on 5.1.1, perhaps M permissions handling hasn't been added yet?

[SaikCaskey]

I've submitted a PR with changes that allow this to work for you

[elbrujohalcon]

It's number #28 (just to link it here).

[erikswed]

Grate Thanks when will you release v2.0.0

[SaikCaskey]

yo he never accepted it or did the changes himself ☹️

my fork still works for O, haven't tested P yet, will likely do so soon. implementation 'com.github.saikcaskey:systemecks-galgo:1.0.1'

please just update this library tho, your CI gadget was wrong to reject my PR

[elbrujohalcon]

Hey @tenmaster @griveroa @quiqueqs … anything to comment here?