erlang-github icon indicating copy to clipboard operation
erlang-github copied to clipboard

Simplify the expected return on egithub_webhook

Open elbrujohalcon opened this issue 10 years ago • 1 comments

Instead of requesting the callback module to find out the commit_id and the position let the module just return filename, line_number and text and do the rest of the processing inside egithub_webhook (use the current implementation in elvis_webhook as a reference).

elbrujohalcon avatar Jan 13 '15 16:01 elbrujohalcon

Also, make sure CommitId is always a binary and not a string.

elbrujohalcon avatar Jan 13 '15 16:01 elbrujohalcon