apns4erl
apns4erl copied to clipboard
inaka
Updated gun to 2.0.0
Based on the work by @jainygaurav on #246 but updated to wok on the newly released 2.0.0 version of cowboy.
I allowed CI to run… but now it fails because Gun doesn't work with old erlangs.
Because of the fixes to crypto made in Erlang 25.1 I can not make this work on anything earlier than that version.
@ferigis that might mean we should bump this to a new major version since it loses compatibility with the all but the latest Erlang versions.
@ferigis I'm tempted to merge this PR and increase the version. I've been using this branch for a while now and I can confirm it works perfectly fine, even if the tests are not passing.
What do you think?
hi @HernanRivasAcosta, sorry for the late response.
Yes, lets bump to a major version.
Thanks
Please use Gun 2.0.1 so you get a Cowlib version that's compatible with OTP-26 otherwise you'll get a compilation error.
@dsrosario: Not on my side. You should ask @ferigis or @HernanRivasAcosta :)
But is there any intension to update the CI to check with latest OTP version (like 26, 25 and 24) instead of the old one's? Maybe some guidance here regarding what Erlang versions to support may help.
gun 2.0.0 is not compatible with OTP20
===> Compiling gun
_build/default/lib/gun/src/gun_socks.erl:142: Warning: a term is constructed, but never used
_build/default/lib/gun/src/gun_socks.erl:147: Warning: a term is constructed, but never used
===> Compiling _build/default/lib/gun/src/gun_http2.erl failed
_build/default/lib/gun/src/gun_http2.erl:922: illegal guard expression
Yeah, usually what we do is to support latest 3 versions. In this case 24, 25 and 26. But, again, I defer to @ferigis and @HernanRivasAcosta for decisions like that on this repo. They're the maintainers and the repo admins.