powermail icon indicating copy to clipboard operation
powermail copied to clipboard

[BUG] plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail.value is ignored

Open glucka opened this issue 5 years ago • 14 comments

The settings

plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail.value 
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToName.value 

is ignored in v7 und v8 I make a PR now.

glucka avatar Jun 23 '20 10:06 glucka

This is still the case in TYPO3 9.5.19 with Powermail 7.4.0. Basically, the constants are correctly set (as per TypoScript Object Browser), but these values are not forwarded when sending the email.

sendMail(array('template' => 'Mail/OptinMail', 'receiverEmail' => '[email protected]', 'receiverName' => 'Peter Griffin', 'senderEmail' => '[email protected]', 'senderName' => 'Test', 'replyToEmail' => '', 'replyToName' => '', 'subject' => 'Bitte bestätigen Sie Ihre Emailadresse', 'rteBody' => '', 'format' => 'both', 'variables' => array('hash ....

This bug is basically preventing us from using the Double OptIn feature.

MrMooky avatar Jul 16 '20 11:07 MrMooky

The PR suggested by @glucka is working, but this should be made available in a TYPO3 9 compatible version. It appears the bug has been fixed in Powermail 8.0.0, which is only compatible with TYPO3 v10.

MrMooky avatar Jul 16 '20 12:07 MrMooky

What shall we do now with powermail in TYPO3 V9!? Wait for a bugfix? Wait for a powermail-upgrade for TYPO3 V9?

kurtkk avatar Jul 18 '20 08:07 kurtkk

Just implement the Commit mentioned above.

MrMooky avatar Jul 18 '20 08:07 MrMooky

@MrMooky can not confirm that this work for TYPO3 9....

Teisi avatar Jul 22 '20 09:07 Teisi

@Teisi @MrMooky I use this in v9

glucka avatar Jul 22 '20 09:07 glucka

@Teisi Worked as expected in our case with TYPO3 9.5.19 and Powermail 7.4.0

MrMooky avatar Jul 22 '20 09:07 MrMooky

@MrMooky what have you done exactly? I have copied and replaced the complete method "parseAndOverwriteVariables"...

Teisi avatar Jul 22 '20 09:07 Teisi

@Teisi I only implemented the new lines mentioned here, nothing else.

MrMooky avatar Jul 22 '20 09:07 MrMooky

@MrMooky hmm, after the change, i'm not getting any e-mails at all... strange. I have to look closer... thank you.

Teisi avatar Jul 22 '20 09:07 Teisi

The code of the commit above does not exist in Powermail V7.4.0 /powermail/Classes/Domain/Service/MailSendMailService.php !?

kurtkk avatar Jul 25 '20 14:07 kurtkk

I just tested powermail 7.4.0 (with latest TYPO3 9) and powermail 8.2.4 (with latest TYPO3 10) with this test settings:

plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail = TEXT
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail.value = [email protected]
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToName = TEXT
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToName.value = test

The generated mail has this header:

Content-Type: multipart/alternative; boundary="_=_swift_v4_1607004812_5ae41346f23f0c89ad8d4cc07d18f88d_=_"
Date: Thu, 03 Dec 2020 15:13:32 +0100
From: defaultmailfromaddress <[email protected]>
MIME-Version: 1.0
Message-ID: <[email protected]>
Received: from powermail95.localhost.de by mailhog.example (MailHog)

          id [email protected]; Thu, 03 Dec 2020 15:13:32 +0100
Reply-To: test <[email protected]>
Return-Path: <[email protected]>
Subject: [testparcours] New Email
To: Alex <[email protected]>
X-Mailer: TYPO3
X-Priority: 3 (Normal)

The question is: How can I reproduce the issue?

einpraegsam avatar Dec 03 '20 14:12 einpraegsam

Maybe only if $GLOBALS['TYPO3_CONF_VARS']['MAIL']['defaultMailReplyToAddress'] is defined?

glucka avatar Dec 11 '20 14:12 glucka

After entering a mail address into $GLOBALS['TYPO3_CONF_VARS']['MAIL']['defaultMailReplyToAddress'] it works fine Thx @glucka

christophbee avatar Oct 07 '22 13:10 christophbee