powermail icon indicating copy to clipboard operation
powermail copied to clipboard

Use constants instead of arbitrary ints in the code

Open mgrundkoetter opened this issue 1 year ago • 1 comments

In the class In2code\Powermail\Domain\Validator\InputValidator in isValidFieldInStringValidation some "random" ints are used to identify the validator. This is bad style from a static analysis point of view and should be replaced by public constants in this class which can then also be used in derived classes.

mgrundkoetter avatar Aug 08 '24 11:08 mgrundkoetter

Thanks. This is correct :-)

We plan to introduce static analysis in the next weeks for powermail and will consider it to improve the situation here.

mschwemer avatar Aug 15 '24 10:08 mschwemer