go-witness icon indicating copy to clipboard operation
go-witness copied to clipboard

Published 20 hours ago • verified publisher icon in-toto

Link & SLSA attestor

Open jkjell opened this issue 1 year ago • 2 comments

Add a new link attestor and the ability to return multiple signed attestation with RunWithExports function.

jkjell avatar Feb 05 '24 12:02 jkjell

some opinionated thoughts from me, one little style thing that I think could be a tiny bit neater, but on the whole I ike the principle of the link connector and providing this way of exposing attestations. Code is also really neat and tidy 😄.

ChaosInTheCRD avatar Feb 05 '24 15:02 ChaosInTheCRD

Did a quick read through of the code and this all looks reasonable. Will pull and play with it tomorrow.

mikhailswift avatar Apr 26 '24 04:04 mikhailswift

provisionally approving, as long as we can resolve https://github.com/in-toto/go-witness/pull/149#discussion_r1552115108

ChaosInTheCRD avatar May 08 '24 17:05 ChaosInTheCRD

Just noticed as well, we need to fix DCO before merge 😄

ChaosInTheCRD avatar May 08 '24 21:05 ChaosInTheCRD