Zhenyu Guo comments

Results 26 comments of


                                            Zhenyu Guo

strerror is not thread safe.

That will definitely help~

May need to bind the socket to io looper before executing connect() and listen().

Thanks, @linmajia. @shengofsun this may be related to the io-looper bug issue, would you please handle this issue together when you debug that problem? thx.

shared log not flush to disk/ssd before return set result to client

There is a currently a `flush` method in `aio_provider`. Can you guys do a survey to see whether flush and fsync are the same thing or not? `aio_fsync` is great...

shared log not flush to disk/ssd before return set result to client

Thanks, @shengofsun. There are two ways to ensure the data is really pushed to disk: `fsync` and use direct io. I guess in our case using direct IO is easier?...

shared log not flush to disk/ssd before return set result to client

Seems O_DIRECT + O_SYNC is good enough. But unfortunately, the buffer should be the same as the situation under Windows that it needs to be aligned. For your questions: -...

shared log not flush to disk/ssd before return set result to client

Let's try and see.

adapt rocksdb benchmark for our system, and generate test result

what is the original number (local rocksdb)?

server state consistency broken

@shengofsun Please also help look into this issue while I'm also trying to figure it out why.

server state consistency broken

The last fix is Commit 01eec618

server state consistency broken

This surfaces again last night. Last time when we fix it, it is because app_info is not appropriately set and is_stateful becomes false which causes incorrect update of the configuration.