Vatsal

Results 20 comments of Vatsal

I analyzed the issue. Here is the analysis: 1- First, we call "func (c *Context) Redirect(code int, location string)". According to documentation, this method "Redirect returns an HTTP redirect to...

@RedCrazyGhost I can't think of a use case where we would want redirect location as an empty string (In relative terms, it would mean the request url itself). I think...

Hi @snicoll I would like to begin contributing to spring framework. Do you mind assigning this to me?

Hi @sbrannen Is it okay if I take a look at this and contribute?

@sbrannen I reproduced this issue [here](https://github.com/imvtsl/spring-framework-reactive-issue-33157/blob/main/src/test/java/com/vatsal/reactive/issue33157/MainTests.java). Netty: io.netty.handler.codec.http.cookie.ClientCookieDecoder.mergeMaxAgeAndExpires() merges Max-Age and Expires into Max-Age. Netty merges these two attributes using logic defined in [RFC 6265](https://datatracker.ietf.org/doc/html/rfc6265#section-5.3). Point 3 of section 5.3...

Hey @sbrannen Thanks for the response. I will raise a PR with this approach and add tests for all `org.springframework.http.client.reactive.ClientHttpResponse` implementations. Out of curiosity, why do we deviate from the...

Hi @sbrannen Thank you for the explanation, appreciate it. I have written tests for `org.springframework.http.client.reactive.ClientHttpResponse` implementations -- for example, `HttpComponentsClientHttpResponse`, `JettyClientHttpResponse`, `ReactorClientHttpResponse`, and `ReactorNetty2ClientHttpResponse` [here](https://github.com/spring-projects/spring-framework/pull/33369/files). It fails for Reactor Netty...

I have raised the [PR](https://github.com/spring-projects/spring-framework/pull/33369) with fix and tests.

Hey @sbrannen Please let me know if there is anything required from my end. I will be on vacation from Thursday to Monday. I will be available to do changes...