Aram Drevekenin

Results 531 comments of Aram Drevekenin
trafficstars

Hey @DeaconDesperado - amazing and very thorough work here! Thank you for your patience and apologies for taking so long to give you an initial review. I'll try to be...

Hey @DeaconDesperado - I'm happy to see the work going on. Kudos on your perseverance and consistency, this looks like quite a great effort! I'm sorry it's taking me a...

Hey @DeaconDesperado - this sounds good (though I will as mentioned wait with going over the exact code until we finalize the product stuff). Including a conversion script is a...

Hey @DeaconDesperado - thanks for putting this together. This is great and really helps me reviewing this PR quickly. I appreciate the clear communication and your meticulousness! This looks really...

> Yes, there is a [`From` impl that applies the members](https://github.com/zellij-org/zellij/pull/3242/files#diff-69611ba79cb44726e08c9207e00cffb933393ee0818fc11366c4860960394ee9R1302) of `Palette` retroactively to all the declarations they would have for a `Styling`. It runs during configuration bootstrapping in...

Hey @DeaconDesperado - first off: fantastic work once again! I had a list of things to check on the compatibility/API level and this implementation passed them with flying colors. The...

> ### 1 > > We can remove this, yeah. The thought behind it had been that perhaps there could be a separate node `colors` where named aliases for colors...

(I just want to make sure we didn't get our wires crossed here - @DeaconDesperado, you're not waiting for me, right? No pressure or anything, just want to make sure...

I'm very sorry, but I think I probably caused some mess for you: https://github.com/zellij-org/zellij/pull/3559 Let me know if you need help with the merge.

Hey, the reproduction is a bit involved so it'll take me some time to get to it - but I want to give you a quick answer so I'm going...