bandwhich icon indicating copy to clipboard operation
bandwhich copied to clipboard

Retry DNS only after timeout

Open imsnif opened this issue 5 years ago • 5 comments

Right now, when we do our reverse-dns queries (getting the hostname of an ip address), if the request failed, we retry immediately. This can cause a lot of connections (also visible in the app!) to be opened if a request repeatedly fails.

It would be nice if we have some sort of progressive backoff mechanism for this... something like: wait for 1 second before retrying, then wait for 2, 4, etc.

imsnif avatar Jan 16 '20 19:01 imsnif

Correct me if I'm wrong, currently we will retry every second?

zhangxp1998 avatar Jan 17 '20 03:01 zhangxp1998

Yep. I have a bit of a spotty internet connection though, so sometimes my whole connections pane is filled with our own DNS requests for minutes on end (which we somehow classify as unknown, btw). I thought this can make things a little friendlier.

imsnif avatar Jan 17 '20 09:01 imsnif

Hi @imsnif I would like to work on it. Could you please give me start point?

captain-yossarian avatar Mar 02 '20 08:03 captain-yossarian

@bigtoast is already working on it here: https://github.com/imsnif/bandwhich/pull/133

imsnif avatar Mar 02 '20 08:03 imsnif

@imsnif it looks like this was never completed and is quite old. Still relevant? Happy to pick it up

QuentinMoss avatar May 12 '23 21:05 QuentinMoss