HacktoSearch icon indicating copy to clipboard operation
HacktoSearch copied to clipboard

Add lint CI/CD

Open WillDaSilva opened this issue 3 years ago • 4 comments

Description

This PR adds ESLint as a dev dependency, a lint config for ESLint, and a GitHub workflow to run ESLint on every push and pull request.

There are currently lint issues, but they were all pre-existing. Maybe another issue should be opened to address them.

Fixes #5

Type of change

  • [X] New feature (non-breaking change which adds functionality)

Screenshots

image

WillDaSilva avatar Oct 01 '21 16:10 WillDaSilva

Someone is attempting to deploy a commit to a Personal Account owned by @imsaptarshi on Vercel.

@imsaptarshi first needs to authorize it.

vercel[bot] avatar Oct 01 '21 16:10 vercel[bot]

I believe the workflow isn't running here because the .github/workflows/lint.yml file has to exist on main. Bit of a chicken and egg problem, but you can verify that it's running on my fork where the workflow config exists.

WillDaSilva avatar Oct 01 '21 16:10 WillDaSilva

Also I have no idea why the package lockfile was so big. Installing ESLint caused npm to automatically remove over 21k lines.

WillDaSilva avatar Oct 01 '21 16:10 WillDaSilva

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saptarshibasu15/hacktosearch/27WT9YzBWebGiZRmAXR429LKPRZB
✅ Preview: Failed

vercel[bot] avatar Nov 08 '21 03:11 vercel[bot]