cobalt icon indicating copy to clipboard operation
cobalt copied to clipboard

More descriptive /api/json response

Open im-trisha opened this issue 1 year ago • 5 comments

describe the feature you'd like to see

  1. I was thinkering with the api, and i had to do an ugly workaround to get the filename, while as far as I'm able to see it could simply be provided in the /api/json request?

  2. In the same way, while thinkering with the api, i found (somewhat) difficult to understand if the downloaded media is a video, or an audio file. Couldn't it be as easy as putting a boolean?

describe alternatives you've considered

  1. Obviously the alternative is to strip it from the content-disposition header got after the GET request to /api/stream
  2. I mean, the alternative i see is just getting the file extension and elaborate from that? I'm not sure though

I hope this is not a stupid request nor has it already been asked. Many thanks!

im-trisha avatar Jun 17 '24 00:06 im-trisha

I have asked cobalt devs, they told me to get the file name on the http request (you can http HEAD to get the file name without needing to download the media)

lostdusty avatar Jun 17 '24 03:06 lostdusty

some code i did to get the filename: https://github.com/lostdusty/gualto/blob/eb43cdb54e59fd3acb46c499d39aedb7081f11b8/main.go#L264-L269

lostdusty avatar Jun 17 '24 03:06 lostdusty

we could totally add the filename to stream response, i see how it can be useful

wukko avatar Jun 17 '24 03:06 wukko

@wukko and what about the api/json response? The endpoint are not as descriptive as they could get, so I'm not sure if its the correct endpoint, but I'd expect from this endpoint every info except the actual file.

And what about the file type?

im-trisha avatar Jun 17 '24 07:06 im-trisha

@lostdusty seems wonderful! I'll use exactly that for the time being :)

im-trisha avatar Jun 17 '24 07:06 im-trisha