cobalt icon indicating copy to clipboard operation
cobalt copied to clipboard

api/soundcloud: add more metadata support

Open nexpid opened this issue 7 months ago • 5 comments

this PR adds and documents the composer, genre and album_artist metadata tags. it also adds more metadata parsing to the soundcloud service:

  • album
  • album_artist
  • composer
  • genre
  • date
  • copyright

why?

having more metadata is always nice. this is a comparison with onthespot in foobar2000

onthespot develop feat/more-metadata
foobar2000_zfKvABMRfN foobar2000_ZNfxyQ3R1x foobar2000_ohvvmuCuLl

PS: invest in a formatter. please

nexpid avatar Jun 02 '25 21:06 nexpid

couldn't find a track with a composer but i pinky promise it gets parsed properly. here's another track which also has a genre specified: image soundcloud sadly (to my knowledge) doesn't tell you the track number of a song

nexpid avatar Jun 02 '25 21:06 nexpid

couldn't find a track with a composer

if you can't find it, then it's probably not there. i wouldn't add something you're not sure in existence of. you can always add it later!

wukko avatar Jun 03 '25 06:06 wukko

if you can't find it, then it's probably not there

turns out I just didn't look hard enough, this song by Imogen Heap has proper credits

{
	"id": 1978104099,
	"urn": "soundcloud:tracks:1978104099",
	"artist": "Imogen Heap",
    // ........
	"writer_composer": "Imogen Heap, Guy Sigsworth",
	"release_title": "Let Go (on the hang in the park)"
}

nexpid avatar Jun 03 '25 17:06 nexpid

@wukko reminder to review again pls

nexpid avatar Jun 05 '25 12:06 nexpid

thought i was PRing to the develop branch? oh well

nexpid avatar Jun 07 '25 20:06 nexpid