ts-protoc-gen icon indicating copy to clipboard operation
ts-protoc-gen copied to clipboard

Published 20 hours ago • verified publisher icon improbable-eng

Change return type of generated setters to the message type

Open craigatron opened this issue 4 years ago • 5 comments

Changes

  • message.ts - changed return type of generated setters to ${messageName}
  • ran npm run generate to regenerate example proto generated code
  • added tests that chain setter calls and verify value on generated object

Verification

Added unit tests for chained setter methods.

craigatron avatar Jun 21 '21 19:06 craigatron

This fix is seriously important for the ts-protoc-gen users (and me). It seems that fixes and tests are good enough (for me). Would it be possible for the maintainers to review again?

Note: This PR fixes #218 #285 .

Update: This PR also fixes #289

gecko655 avatar Aug 18 '21 14:08 gecko655

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarcusLongmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

improbable-prow-robot avatar Nov 08 '21 11:11 improbable-prow-robot

Just ran into this issue trying to update definitions. It looks like this PR is approved - any reason it can't be checked in and pushed out in a new version? Anything I can do to help?

chris-codaio avatar Feb 01 '22 04:02 chris-codaio

Bumping this PR... is there any reason this can't be merged?

thompsonja avatar Aug 10 '22 14:08 thompsonja

bump

gonzojive avatar Oct 26 '22 01:10 gonzojive