fix: Expose `message` on ClientStream Service stubs

[George-Payne]

Changes

• Add optional callback to clientStream to return response.
• Callback is called after end event
• Amend types with overload for optional metadata

Verification

Tested generated code:

• both metadata and callback
• only callback
• only metadata
• neither

fixes: #208

[George-Payne]

/assign @moadz

[watjurk]

Hi, is there a chance of this PR getting merged ? Thanks !

[improbable-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [moadz]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[edaniels]

Can we get this merged in?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jucrouzet]

Hi @MarcusLongmuir @moadz ,

Is there a chance to have this merged or any update that can fix this problem ?

Regards,

[improbable-prow-robot]

New changes are detected. LGTM label has been removed.

[MarcusLongmuir]

I pushed changes to this to fix a callback ordering issue and added integration tests. Thanks for the contribution 👍

[improbable-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarcusLongmuir, moadz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [MarcusLongmuir]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[jucrouzet]

Thanks a lot