grpc-web icon indicating copy to clipboard operation
grpc-web copied to clipboard

Bump nhooyr.io/websocket

Open alexpyc opened this issue 1 year ago • 3 comments

Versions of relevant software used

0.15.0

What happened

The captioned module removed releases of v1.8.6 from GitHub: https://github.com/nhooyr/websocket-old/tags

What you expected to happen

Successful go mod vendor

How to reproduce it (as minimally and precisely as possible):

go mod vendor in a project that imports this repository (grpcweb)

Full logs to relevant components

go: downloading nhooyr.io/websocket v1.8.6
go: github.com/improbable-eng/[email protected] requires
	nhooyr.io/[email protected]: reading nhooyr.io/websocket/go.mod at revision v1.8.6: unknown revision v1.8.6

Anything else we need to know

alexpyc avatar Aug 13 '24 11:08 alexpyc

not using grpc-web, but also have the same error. You need to replace nhooyr.io/websocket with github.com/coder/websocket as the old project has been deprecated and moved to Coder (ref: https://coder.com/blog/websocket) sample replace:

replace nhooyr.io/websocket => github.com/coder/websocket v1.8.7

farisekananda avatar Aug 14 '24 00:08 farisekananda

Oh, hello there. Arriving from a botched go build with alpaca 1.9.0 as a dependency. farisekananda's solution works.

iamwhil avatar Aug 26 '24 15:08 iamwhil

Hi there, same problem here... But I want to proxify my builds for traceability and SLSA 3, so cannot put a replace directive in my go.mod.

Does it require a PR ? I can do so if necessary

pandatix avatar Dec 29 '24 14:12 pandatix