givewp icon indicating copy to clipboard operation
givewp copied to clipboard

Hotfix: `give_goal` and `give_form` display the goal progress correctly

Open JoshuaHungDinh opened this issue 3 years ago • 0 comments

Resolves #6563

Description

The PR removes a get_id() Wordpress function in the give_goal shortcode. The function is not needed and causing the shortcode to fail when rendering. It was an oversight from PR https://github.com/impress-org/givewp/pull/6541. Because the Legacy template relies on give_goal to display the goal progress - fixing the issue in give_goal has corrected the issue with give_form while using a legacy template.

Affects

give_goal shortcode

Visuals

https://user-images.githubusercontent.com/75056371/191848931-c33b6e21-afe5-44d6-9131-03fc89b94dee.mov

Testing Instructions

  • Create a form with the Legacy template.
  • Enable & set donation goal options to amount raised.
  • Process a donation.
  • Create a page using give_goal, give_form shortcodes & the Donation Form Block
  • View Page to verify the goal section displays.
  • Change the donation goal to each different option and view the page for each option to verify the different goal options continue to work.

Pre-review Checklist

  • [x] Acceptance criteria satisfied and marked in related issue
  • [ ] Relevant @unreleased tags included in DocBlocks
  • [ ] Includes unit tests
  • [ ] Reviewed by the designer (if follows a design)
  • [x] Self Review of code and UX completed

JoshuaHungDinh avatar Sep 22 '22 20:09 JoshuaHungDinh