eslint-plugin-import
eslint-plugin-import copied to clipboard
import-js
fix(import/order): do not compare first path segment for relative paths
Should fix the regression in #2682.
The gist of the fix is that for relative paths, siblings always start with "." and parents always start with "..". When comparing them, it will always result in "." being first, which was the bug. The sorting based on subpath segments should start from the second path segment, when there is a possibility that one of them is different.
@ljharb added! This was a good suggestion, as that particular case needed additional handling.
Not sure what is going on with the failing actions, do not seem related to my changes?
Hi everyone, do you reckon this PR has a reason to be blocked? Like a lot of people, I've been sticking with v2.26.0 of this plugin since https://github.com/import-js/eslint-plugin-import/issues/2682 has been a thing, and I'd very much like to get back to being up-to-date and with imports in the right order 😉
Any news here? PR looks fine, any blockers I can help getting rid of?
I think while my fix does work for some of the reported issues, some would still not be fixed by this, e.g. https://github.com/import-js/eslint-plugin-import/issues/2722
I could not fix the other issues, so gave up as it does not affect my usecases as much. But probably would help if the fix would resolve all of the different issues that have been reported.