eslint-plugin-import icon indicating copy to clipboard operation
eslint-plugin-import copied to clipboard

[Docs] order: update the description of the `pathGroupsExcludedImportTypes` option

Open liby opened this issue 3 years ago • 1 comments

Motivation: #2156

#1665 I read this issue and knowing why we had this PR, but I think they use pathGroupsExcludedImportTypes in the wrong way. If we need to let pathGroup works, sometimes we have to add pathGroupsExcludedImportTypes as [].

@Mairu @Akiq2016 @yola-0316 PTAL.

liby avatar Sep 28 '21 03:09 liby

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.63%. Comparing base (dd81424) to head (74450a3). Report is 295 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
- Coverage   95.23%   94.63%   -0.60%     
==========================================
  Files          65       65              
  Lines        2686     2686              
  Branches      888      888              
==========================================
- Hits         2558     2542      -16     
- Misses        128      144      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 28 '21 04:09 codecov[bot]

Sorry, I missed this PR when it was opened, but yes the changes are correct and the current documentation is wrong. Using patterns as excluded types works accidentally because the default types are removed.

Mairu avatar Aug 15 '24 06:08 Mairu

it's very unfortunate that the fork was deleted, making this PR unrecoverable, so now we need #3036 as a duplicate :-/

please never delete a fork that has open PRs.

ljharb avatar Aug 15 '24 18:08 ljharb