eslint-plugin-import
eslint-plugin-import copied to clipboard
[Fix] `no-relative-parent-imports`: check unresolved dependency type
Fixes #1610
I couldn’t actually test this code, because I couldn’t even figure out how to run the existing tests. (I tested that it fixes the issue by actually hacking the fix by hand in my copy of eslint-plugin-import
in my project’s node_modules
...)
Also, I’m not really sure I 100% understand what the old code was trying to do, and why it didn’t already do what I did in this change. So, maybe look carefully at it?
Coverage increased (+0.002%) to 97.908% when pulling 2e13c09870aaedc4686b68007c3be6d0bcc39b0e on bogdanb:fix-1610 into c51b6a97de1e0edad77a247d5da4c36db7c8d039 on benmosher:master.
All the current tests pass, which is a great sign :-)
We do need to figure out how to add a regression test, though.
On the repro repo, your change doesn't cause eslint errors to appear :-/