eslint-plugin-import icon indicating copy to clipboard operation
eslint-plugin-import copied to clipboard

glob pattern in `except` option of the `no-restricted-paths` rule

Open KevinHerklotz opened this issue 5 years ago • 10 comments

Allow to also pass a glob pattern to the except option of the no-restricted-paths rule. Before you could only add a relative path. This is still working and the new glob pattern is also only working in the relative path.

I also improved the documentation in general.

Fixes #1701

KevinHerklotz avatar Mar 29 '20 21:03 KevinHerklotz

Coverage Status

Coverage increased (+0.01%) to 97.918% when pulling 888443e5731489c40b949b5255dc8fab7304090c on KevinHerklotz:add-glob-to-except into ff50964df1234515bc6f7969b90d87ada1982008 on benmosher:master.

coveralls avatar Mar 29 '20 22:03 coveralls

Coverage Status

Coverage increased (+0.01%) to 97.808% when pulling a108a4a627f60ee317d27e3fd0dd3bde91ca058e on KevinHerklotz:add-glob-to-except into 71ca88f0a1e7e1270f1c1f9633d3ae8f136f58e1 on benmosher:master.

coveralls avatar Mar 29 '20 22:03 coveralls

Coverage Status

Coverage increased (+0.01%) to 97.808% when pulling a108a4a627f60ee317d27e3fd0dd3bde91ca058e on KevinHerklotz:add-glob-to-except into 71ca88f0a1e7e1270f1c1f9633d3ae8f136f58e1 on benmosher:master.

coveralls avatar Mar 29 '20 22:03 coveralls

Coverage Status

Coverage increased (+0.01%) to 97.808% when pulling a108a4a627f60ee317d27e3fd0dd3bde91ca058e on KevinHerklotz:add-glob-to-except into 71ca88f0a1e7e1270f1c1f9633d3ae8f136f58e1 on benmosher:master.

coveralls avatar Mar 29 '20 22:03 coveralls

Coverage Status

Coverage increased (+0.01%) to 97.808% when pulling a108a4a627f60ee317d27e3fd0dd3bde91ca058e on KevinHerklotz:add-glob-to-except into 71ca88f0a1e7e1270f1c1f9633d3ae8f136f58e1 on benmosher:master.

coveralls avatar Mar 29 '20 22:03 coveralls

Coverage Status

Coverage increased (+0.01%) to 97.808% when pulling a108a4a627f60ee317d27e3fd0dd3bde91ca058e on KevinHerklotz:add-glob-to-except into 71ca88f0a1e7e1270f1c1f9633d3ae8f136f58e1 on benmosher:master.

coveralls avatar Mar 29 '20 22:03 coveralls

Coverage Status

Coverage increased (+0.01%) to 97.808% when pulling a108a4a627f60ee317d27e3fd0dd3bde91ca058e on KevinHerklotz:add-glob-to-except into 71ca88f0a1e7e1270f1c1f9633d3ae8f136f58e1 on benmosher:master.

coveralls avatar Mar 29 '20 22:03 coveralls

The CI is failing and I think the error message is not due to my changes. So I close the PR and reopen it again to trigger a rebuild. This was the error:

$ nvm install lts/*
Downloading and installing node v12.16.1...
Downloading https://nodejs.org/dist/v12.16.1/node-v12.16.1-linux-x64.tar.xz...
curl: (56) GnuTLS recv error (-110): The TLS connection was non-properly terminated.
Binary download from https://nodejs.org/dist/v12.16.1/node-v12.16.1-linux-x64.tar.xz failed, trying source.
grep: /home/travis/.nvm/.cache/bin/node-v12.16.1-linux-x64/node-v12.16.1-linux-x64.tar.xz: No such file or directory
Provided file to checksum does not exist.
Binary download failed, trying source.

KevinHerklotz avatar Mar 30 '20 07:03 KevinHerklotz

To be honest I'm a bit lost now and don't really understand why the tests are failing. The error messages are not really helpful for me. Help from someone else is much appreciated.

KevinHerklotz avatar Jan 08 '21 09:01 KevinHerklotz

@KevinHerklotz sorry for the delay. i've partially rebased this, and tests seem to be passing locally :-) but it'll need another rebase onto latest master.

ljharb avatar Aug 08 '21 16:08 ljharb