eslint-plugin-import icon indicating copy to clipboard operation
eslint-plugin-import copied to clipboard

Published 20 hours ago • verified publisher icon import-js

Add requireResolve option

Open vikr01 opened this issue 6 years ago • 7 comments

Closes #585

Alternate to #1216

Adds an option requireResolve to check require.resolve statements.

Might want to support require.resolve by default in a future major version though.

vikr01 avatar Oct 21 '18 05:10 vikr01

Coverage Status

Coverage increased (+0.09%) to 97.349% when pulling 4773c69a16de85ec02db627c5ceed78e64d2077a on vikr01:feature/require-resolve-option into b4a2f11fcacc6b2f048da4b29cfc896e682f17d1 on benmosher:master.

coveralls avatar Oct 21 '18 05:10 coveralls

Coverage Status

Coverage increased (+0.003%) to 97.36% when pulling 1d387cf2a995f509c325b7da6680949416d64856 on vikr01:feature/require-resolve-option into db471a85573a88e0bb9f4a1d53f40fed603651d1 on benmosher:master.

coveralls avatar Oct 21 '18 05:10 coveralls

There was no need for a separate PR, for future reference.

I'll keep both PRs updated.

ljharb avatar Oct 21 '18 20:10 ljharb

@benmosher Could you review this when you have a chance?

vikr01 avatar Feb 03 '19 20:02 vikr01

Hello, any reason why this is not merged? I'd also love to have this functionality. I am also happy to change - can deal with the conflicts and test. Just wouldn't want to do the extra work if there is a separate reason for this not being considered anymore. Thanks!

lgandecki avatar Oct 26 '20 07:10 lgandecki

@ljharb I'm happy to rebase and do the necessary work.
It seems to me that this PR does have test cases, are there any specifics that you would like to be added?

lgandecki avatar Feb 16 '21 07:02 lgandecki

@lgandecki that'd be great!

current tests look OK, but the more the better :-) in general, for every new test case, i'd prefer it to be tested in each parser, and both with and without the new option.

ljharb avatar May 14 '21 05:05 ljharb