Adding new group types and matching pattern for sort order

[6graNik]

I added support for couple of new types.

One that was internally used absolute and one new private

They both for more flexible order customazing, we need it in our project and I thought maybe some one else will need it to.

Both properties have on pattern field that except regex.

[coveralls]

Coverage increased (+0.02%) to 96.499% when pulling 33cda362518cb636ad71a6118f85e27a22723ff9 on 6graNik:new-group-types into cfd437791ae8c358475a71defa7c47e3f68a3d09 on benmosher:master.

[ljharb]

Absolute has a meaning, this seems fine. I have no idea what “private” means, nor why it needs to be a default group when you can create custom ones.

Either way, please update the documentation to describe all your changes.

[6graNik]

@ljharb How can we create custom types? May be I missed it in docs. But right now I only see The only allowed strings are: "builtin", "external", "internal", "parent", "sibling", "index" (https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md)

I created them because I thought we can't create custom ones. And my idea was to separate private company/project package imports from external

I think you are right that we don't need them as a default.

I will update docs accordingly.

[ljharb]

Ah, you’re right, I’m thinking of a different rule in a different plugin.

What would you expect “private” to mean, given that this isn’t a standard concept in node?

[6graNik]

@ljharb As I said before in my idea private type imports is for company or project level packages/libs, to separate them logically from all external types

[6graNik]

I think something wrong with your CI because locally all test completes successfully.

[chenders]

@6graNik FWIW, when I run the tests on your branch I get the same errors that are happening in the CI.

[lucasveigaf]

This PR would solve my use case, which is to group company projects. There are some corner cases, which can only be solved by being able to register a group via regex. Any progress on this?

[jeffshaver]

@ljharb thanks for the response and pointing me to this issue. Is there something that needs to be done to get this in? Anything I can do to help?

[ljharb]

See https://github.com/benmosher/eslint-plugin-import/pull/1076#issuecomment-380503393

In other words, I'm fine to add builtin groups that have a reasonable universal meaning; "private" has none.

[jeffshaver]

@ljharb after reading the docs again and reading the source for the order rule, can you correct me if I'm wrong? Does the "internal" group refer to things that basically look like node modules (no relative paths or whatever) but don't exist in the node_modules folder? If so, I think that group solves the Typescript alias problem and we wouldn't require any changes to switch to this.

[6graNik]

If your concern only, about naming, we can defenatly change it from private to whatever. I am not a native English speaker, so may be someone could suggest any proper naming.

Basically we want to add opportunity to group "some" imports, to separate them from other predefined ones. I need it to group some out company projects.

[jeffshaver]

@ljharb After trying to get a minimal project up and running given what we talked about, it seems like I found an issue. Made a new issue so that I don't keep bombing this pr thread. https://github.com/benmosher/eslint-plugin-import/issues/1293

[ljharb]

@6graNik you can create a custom group already; why is that not sufficient?

[jeffshaver]

@ljharb is that documented somewhere?

[ljharb]

ah, perhaps not; in which case, would a feature to create custom groups be a better solution for this?