eslint-import-resolver-typescript icon indicating copy to clipboard operation
eslint-import-resolver-typescript copied to clipboard

chore(deps): remove `is-core-module` dependency

Open wojtekmaj opened this issue 1 year ago • 3 comments

Node.js from v6.13.0, v8.10.0, v9.3.0 includes module.builtinModules which we can use to natively check if some module belongs to Node.js core or not.

This drops not one, but three dependencies, removing 70 KB of bloat: https://npmgraph.js.org/?q=is-core-module

wojtekmaj avatar Jun 28 '24 08:06 wojtekmaj

🦋 Changeset detected

Latest commit: 96951da389a58b3800c737df3033e7414bba685f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 28 '24 08:06 changeset-bot[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jun 28 '24 08:06 codesandbox-ci[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 31.1 kB ljharb

🚮 Removed packages: npm/@types/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Jul 14 '24 15:07 socket-security[bot]

CI is broken due to linting.

JounQin avatar Jul 14 '24 15:07 JounQin

Heads up that this will break for node:test, node:sea, and node:sqlite, which aren't in that list (nor will any new prefix-only core modules). is-core-module handles it, however.

ljharb avatar Jul 16 '24 22:07 ljharb