eslint-import-resolver-typescript icon indicating copy to clipboard operation
eslint-import-resolver-typescript copied to clipboard

fix: ignore bun built-in modules

Open SunsetTechuila opened this issue 1 year ago • 6 comments

supersedes #266

npm link

SunsetTechuila avatar Jun 03 '24 17:06 SunsetTechuila

🦋 Changeset detected

Latest commit: fcfd225034109e7a5f68d9ef052d88c04b08f5c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 03 '24 17:06 changeset-bot[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jun 03 '24 17:06 codesandbox-ci[bot]

btw this https://github.com/import-js/eslint-import-resolver-typescript/blob/ca11f1c538714252ff058a8e1c680796ee5775d0/src/index.ts#L163 can be changed to

builtinModules.includes(source.replace(/^node:/, ''))

see https://nodejs.org/api/module.html#modulebuiltinmodules

SunsetTechuila avatar Jun 08 '24 21:06 SunsetTechuila

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Jun 16 '24 19:06 socket-security[bot]

@JounQin hello, would appreciate a review from you

SunsetTechuila avatar Jun 28 '24 18:06 SunsetTechuila

@SukkaW would you mind reviewing my pr as well please? it doesn't look like JounQin will have time for that any time soon

SunsetTechuila avatar Jul 12 '24 14:07 SunsetTechuila

@SukkaW would you mind reviewing my pr as well please? it doesn't look like JounQin will have time for that any time soon

Currently, I don't have access to the eslint-import-resolver-typescript package yet, thus I can't get my hand on maintaining this. The PR LGTM though.

SukkaW avatar Jul 13 '24 08:07 SukkaW

@SunsetTechuila Sorry for the delay, could be rebase this PR?

@ljharb Is that possible to add @SukkaW as collaborator of this repository also?

JounQin avatar Jul 14 '24 15:07 JounQin

done

ljharb avatar Jul 14 '24 15:07 ljharb

rebased

SunsetTechuila avatar Jul 14 '24 15:07 SunsetTechuila

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 3.96 kB isaacs
npm/[email protected] None +1 105 kB sunset_techuila
npm/[email protected] None 0 22.8 kB doowb
npm/[email protected] None 0 42.3 kB chalker
npm/[email protected] None 0 805 kB tromey
npm/[email protected] None 0 5.48 kB tootallnate

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Jul 14 '24 15:07 socket-security[bot]