eslint-import-resolver-typescript icon indicating copy to clipboard operation
eslint-import-resolver-typescript copied to clipboard

Case study: `tsconfck` vs `get-tsconfig`

Open JounQin opened this issue 6 months ago • 11 comments

https://github.com/dominikg/tsconfck

vs

https://github.com/privatenumber/get-tsconfig

cc @privatenumber

JounQin avatar Dec 11 '23 03:12 JounQin

Why was I tagged?

privatenumber avatar Dec 11 '23 08:12 privatenumber

Why was I tagged?

@privatenumber I don't know if you know about tsconfck, I'm currently using get-tsconfig in several projects, but it seems it's missing some features different from tsconfck, would they be supported?

JounQin avatar Dec 11 '23 08:12 JounQin

missing some features different

What are they? And why don't you open a discussion thread in get-tsconfig with a clear question instead of tagging me on multiple issues with no question?

privatenumber avatar Dec 11 '23 09:12 privatenumber

What are they?

Take references for example.

resolve "references" of solution-style tsconfig

And why don't you open a discussion thread in get-tsconfig with a clear question instead of tagging me on multiple issues with no question?

I'm sorry if I was bothering you. I was just opening the two issue in case I could forget these tasks and tagging you in case you may want to take a look at tsconfck.

JounQin avatar Dec 11 '23 09:12 JounQin

Feel free to submit feature requests in get-tsconfig. However, please make ensure that your suggestions are well-detailed and with context. Your thorough input will be appreciated.

And in the future, please initiate constructive discussions in the relevant repositories. Others may have similar questions, and it's more discoverable in the appropriate places. Thanks!

privatenumber avatar Dec 11 '23 09:12 privatenumber

@JounQin Since tsconfck claims to be faster and smaller, there is no reason that why we should not replace the get-tsconfig.

In fact, I am going to replace get-tsconfig w/ tsconfck in the rollup-plugin-swc3.

SukkaW avatar Dec 27 '23 14:12 SukkaW

@SukkaW Thanks for your input, but tsconfck breaks my workflow currently described at https://github.com/dominikg/tsconfck/issues/149. And I don't know if jsconfig.json is supported, see also https://github.com/dominikg/tsconfck/issues/14.

cc @dominikg

JounQin avatar Dec 27 '23 15:12 JounQin

jsconfig.json is supported in tsconfck v3, but you need to explicitly enable it with an option, there is no automatic/hybrid mode where it looks for tsconfig.json or jsconfig.json simultaneously https://github.com/dominikg/tsconfck/pull/132

tsconfck is also used by vite, and there have been previous discussions about making it available to vite plugins to avoid multiple plugins all using it with separate caches. We should start a discussion on vite discord about that maybe?

dominikg avatar Dec 27 '23 15:12 dominikg

@dominikg Sorry I'm not a native English speaker, I don't quite understand what do you want to discuss about? Automatically seeking jsconfig.json when tsconfig.json not found or not specific passed as option.

JounQin avatar Dec 28 '23 01:12 JounQin

@SukkaW Thanks for your input, but tsconfck breaks my workflow currently described at dominikg/tsconfck#149. And I don't know if jsconfig.json is supported, see also dominikg/tsconfck#14.

@SukkaW In case that my questions seem already been fixed after https://github.com/dominikg/tsconfck/releases/tag/tsconfck%403.0.1, do you want to raise to PR to replace get-tsconfig w/ tsconfck, or I'll do it when I'm free.

See also https://github.com/un-es/eslint-plugin-i/issues/20

JounQin avatar Jan 04 '24 08:01 JounQin

@SukkaW Thanks for your input, but tsconfck breaks my workflow currently described at dominikg/tsconfck#149. And I don't know if jsconfig.json is supported, see also dominikg/tsconfck#14.

@SukkaW In case that my questions seem already been fixed after https://github.com/dominikg/tsconfck/releases/tag/tsconfck%403.0.1, do you want to raise to PR to replace get-tsconfig w/ tsconfck, or I'll do it when I'm free.

See also un-es/eslint-plugin-i#20

I am also kinda busy lately. I am gonna dig through the tsconfck a little more when I can get some time.

SukkaW avatar Jan 04 '24 13:01 SukkaW