Eric Cheng
Eric Cheng
> I have no problem with the name (maybe casing `ID` vs `Id`). But I'm not sure about the module. I didn't understood how this relates to any file system...
> For a start, we should add options to internetDomainName. Namely domainWords: number and reverse: boolean Then the bundleId would just be some kind of alias. From what I can...
> > My bad if I'm missing something here, but why would `domainWords` be a number? > > Maybe `domainWordCount`? > > > Also, I think a `reverse` param for...
> @import-brain Are your target audience normal users or technical developers? > If first => you should try to not confuse your customers with such technical bundle ids. > >...
> IMO since you have a need for it and it doesnt have much of an impact, we can add it. I think the hacker(developer) module would fit best. `faker.hacker.appleBundleId`...
> > Are you sure we should mark them using jsdoc alias tags? > > I think this increases awareness of the other methods. So if you spot appleBundleId and...
> We should definitely have a space where we could put all locale-independent definitions. Not sure we should call it `global` locale though as it's not connected with anything i18n....
> I would like to try contribute to this issue if it still hasn't been resolved. Can you assign to me? Sure!
> @import-brain > > I took the regex from our tests and manually verified it at https://regexr.com/ > > I believe our bitcoin address generation is wrong. > > Should...
> I don't know say which is correct, I searched and almost all of the sites don't says the same thing about valid bitcoin address Yeah, pretty much all websites...