mopidy-bandcamp icon indicating copy to clipboard operation
mopidy-bandcamp copied to clipboard

Published 20 hours ago • verified publisher icon impliedchaos

bndcmpr playlists?

Open natumbri opened this issue 1 year ago • 3 comments

Any interest in supporting bndcmpr playlists?

see https://github.com/natumbri/mopidy-bandcamp/commit/fb1dd93df200d5d1a679c5ae62c9a6e8f89dd189

Cheers, Nik

natumbri avatar Dec 13 '23 11:12 natumbri

Absolutely! I'm overloaded with work right now, but I'll try to get this merged and the docs updated this weekend. Thanks!

impliedchaos avatar Dec 13 '23 15:12 impliedchaos

If you're interested, I can put together a proper pull request that is a bit tidier and limited to strictly what is required.

One question: how do you feel about multi-threading? Without multi-threading, it takes a while to look up a long playlist; parallelizing makes it quicker, obviously, but involves adding a new import, and hitting bandcamp.com harder.

There is probably an even better alternative, to process the bndcmpr playlist sequentially using pykka futures, so that the mopidy queue is updated as each track is processed, instead of all at once. But that is beyond my capacity right now.

natumbri avatar Dec 13 '23 20:12 natumbri

Hi Nik,

Yeah, a PR would be fantastic.

And, I don't have a problem with threading.

Thanks, Dave

impliedchaos avatar Dec 13 '23 20:12 impliedchaos