terraform-provider-incapsula icon indicating copy to clipboard operation
terraform-provider-incapsula copied to clipboard

missing minify/compress toggle

Open n0npax opened this issue 3 years ago • 0 comments

Hi,

issue https://github.com/imperva/terraform-provider-incapsula/issues/35 was very similar, but was closed.

Screen Shot 2021-08-26 at 4 53 41 pm

I don't see minify/compress switches exposed by TF provider(https://registry.terraform.io/providers/imperva/incapsula/latest/docs/resources/site)

resource "incapsula_site" "example-site" {
  domain                 = "examplesite.com"
  account_id             = 123
  ref_id                 = "123"
  send_site_setup_emails = "false"
  site_ip                = "2.2.2.2"
  force_ssl              = "false"
  logs_account_id        = "456"
  data_storage_region    = "US"
  hashing_enabled        = true
  hash_salt              = "foobar"
  log_level              = "full"
  # Performance
  perf_client_comply_no_cache              = true
  perf_client_enable_client_side_caching   = true
  perf_client_send_age_header              = true
  perf_key_comply_vary                     = true
  perf_key_unite_naked_full_cache          = true
  perf_mode_https                          = "include_all_resources"
  perf_mode_level                          = "standard"
  perf_mode_time                           = 1000
  perf_response_cache_300x                 = true
  perf_response_cache_404_enabled          = true
  perf_response_cache_404_time             = 1000
  perf_response_cache_empty_responses      = true
  perf_response_cache_http_10_responses    = true
  perf_response_cache_response_header_mode = "custom"
  perf_response_cache_response_headers     = ["Access-Control-Allow-Origin", "Foo-Bar-Header"]
  perf_response_cache_shield               = true
  perf_response_stale_content_mode         = "custom"
  perf_response_stale_content_time         = 1000
  perf_response_tag_response_header        = "Example-Tag-Value-Header"
  perf_ttl_prefer_last_modified            = true
  perf_ttl_use_shortest_caching            = true
}

Can I ask if minify toggle is supported

I see minify key exist in a code only for Response struct

https://github.com/imperva/terraform-provider-incapsula/blob/a8ff12b8fe01ae27a669e32e59ded51b30f90a3e/incapsula/client_site.go#L37

https://github.com/imperva/terraform-provider-incapsula/blob/a8ff12b8fe01ae27a669e32e59ded51b30f90a3e/incapsula/client_site.go#L181-L183

n0npax avatar Aug 26 '21 07:08 n0npax