NodeJs-Sample icon indicating copy to clipboard operation
NodeJs-Sample copied to clipboard

maxAge is incorrect in express-configuration

Open JosephScript opened this issue 9 years ago • 0 comments

In the file express-configuration/index.js the maxAge is logged as one day but in reality is set to one year.

console.log("Setting 'Public' folder with maxAge: 1 Day.");
    var publicFolder = path.dirname(module.parent.filename)  + "/public";
    var oneYear = 31557600000;
    app.use(express.static(publicFolder, { maxAge: oneYear }));

Since setting public cache to one year is the maximum recommended, I suggest changing the log to the following:

console.log("Setting 'Public' folder with maxAge: 1 Year.");
    var publicFolder = path.dirname(module.parent.filename)  + "/public";
    var oneYear = 31557600000;
    app.use(express.static(publicFolder, { maxAge: oneYear }));

The other option is to use 86400000 milliseconds such as the following:

console.log("Setting 'Public' folder with maxAge: 1 Day.");
    var publicFolder = path.dirname(module.parent.filename)  + "/public";
    var oneDay = 86400000;
    app.use(express.static(publicFolder, { maxAge: oneDay }));

Thanks!

JosephScript avatar Jun 17 '15 01:06 JosephScript