pcg-cpp icon indicating copy to clipboard operation
pcg-cpp copied to clipboard

using forward declarations for iostream

Open eiennohito opened this issue 10 years ago • 2 comments

Forward declaration is sufficient for the library.

eiennohito avatar Dec 21 '14 03:12 eiennohito

I could merge this, but pcg_extras.hpp includes iostream anyway, so it doesn't save us anything to bring in the forward declarations.

Do you see some big win in making this change?

imneme avatar Mar 12 '15 23:03 imneme

Forward declarations are 'optimizations' for the compile time and matter for big projects. And there is a possibility that somebody would not want iostream include at all. Forward declarations provide least sufficient information for libraries and it is better to use them.

eiennohito avatar Mar 23 '15 11:03 eiennohito