pcg-cpp
pcg-cpp copied to clipboard
Dead and untested code
Things I noticed by hand:
-
struct rxs_mixin
has its function calledoutput_rxs
rather than just plainoutput
, which would prevent it from being used as anoutput_mixin
if it were ever used. -
may_tock
is always false in the testsuite, so those branches aren't tested. - A bunch of
x ? expr : 0
wherex
can never be 0. Since the expression is usually a shift, it should probably be asafe_shift
function though. -
operator-
on extended generators after a step that can't be represented in a singleitype
.
Things I noticed missing from my port's coverage report:
- Half of
pcg_engine
is ever tested (noticed because all the template-typedefs have to be functions in python) - both overloads of
extended.advance_table
, both methods ininsideout
, allunoutput
functions, andunxorshift
are never tested. -
unique_stream.stream()
andoneseq_stream.stream()
Probably should be covered byoperator ==
. -
engine.wrapped
-
engine.operator ==
andextended.operator ==
-
rxs_mixin
,rxs_m_mixin
,xsh_mixin
,xsl_mixin
-
extended.set
-
extended.advance
in the forward direction. Probably applies toengine
too ... and won'tdiscard
malfunction?
Some of these may be used in the samples, but those aren't run as part of the test suite, so can't be demonstrated to work.