immutables icon indicating copy to clipboard operation
immutables copied to clipboard

Cannot use stagedBuilder=true and @Value.Enclosing

Open dsinghvi opened this issue 2 years ago • 3 comments

If the outer class is annotated with @Value.Enclosing and a nested interface/abstract class is annotated with @Value.Style(stagedBuilder = true) then the generated immutable class doesn't actually have a staged builder.

dsinghvi avatar Apr 07 '22 00:04 dsinghvi

@elucash this is really important for me and I'd love to make the change -- do you think you would accept it?

dsinghvi avatar Apr 28 '22 00:04 dsinghvi

@dsinghvi sorry for the late response. This seems like omission and something which is fixable. Are you referring to providing PR for this or just asking if this is something that can be fixed? Have nothing against it, but it might involve some (potentially) fragile change.

elucash avatar Apr 28 '22 02:04 elucash

@elucash would be happy to provide a PR for this -- any pointers as to where to look?

dsinghvi avatar Aug 15 '22 06:08 dsinghvi