immunarch icon indicating copy to clipboard operation
immunarch copied to clipboard

Problem generating mds plot after repOverlap

Open peter-yufan-zeng opened this issue 4 years ago • 10 comments

🐛 Bug

Hi There, I am running into an error while trying to graph with vis after repOverlap, exactly as detailed in the manual

To Reproduce

Steps to reproduce the behavior:

imm_ov1 = repOverlap(immdata.opc$data, .method = "public", .verbose = T)
vis(repOverlapAnalysis(imm_ov1, "mds+kmeans"))

it gives an error .by="cluster", .meta=immdata.opc$meta

However, when I run vis(repOverlapAnalysis(imm_ov1, "tsne"))

there is no problem.

This is what the beginning of print(imm_ov1) looks like

image

I think it might be due to the NAs in the middle. Thoughts?

Thanks in advance for your help

Expected behavior

Additional context

peter-yufan-zeng avatar Mar 02 '20 21:03 peter-yufan-zeng

Hi @peter-yufan-zeng

sorry for the late response! Is it possible to replace NAs and try again if it works?

res = repOverlapAnalysis(imm_ov1, "mds+kmeans")
res[is.na(res)] = 0

vadimnazarov avatar Apr 12 '20 14:04 vadimnazarov

Ping about the repOverlap MDS issues @peter-yufan-zeng

vadimnazarov avatar May 04 '20 18:05 vadimnazarov

Replacing the NA's still throws error

Error in MASS::isoMDS(.data, k = 2, trace = F) : zero or negative distance between objects 1 and 2

peter-yufan-zeng avatar May 07 '20 01:05 peter-yufan-zeng

Thank you, will look into this as well. Thank you a lot for coming back and helping us improve the package, @peter-yufan-zeng !

vadimnazarov avatar May 07 '20 01:05 vadimnazarov

@vadimnazarov no problem. I am a huge fan of the package and appreciate your help 👍

peter-yufan-zeng avatar May 07 '20 01:05 peter-yufan-zeng

Having the same issue, thanks!

DCGenomics avatar Nov 10 '20 18:11 DCGenomics

Same for me.

Manikgarg avatar Jan 12 '21 11:01 Manikgarg

Hi,

I am having the same issue. Is there any solution for this error?

Thanks! Parvathi.

parvathisudha avatar Oct 23 '23 18:10 parvathisudha

Hi, I tried to reproduce it on the dev version of immunarch and test data data(immdata), but I don't have any problems. Could you share the overlap matrix here? What version of the package are you using?

vadimnazarov avatar Oct 24 '23 00:10 vadimnazarov