c2rust icon indicating copy to clipboard operation
c2rust copied to clipboard

Turn on `clippy` in CI

Open kkysen opened this issue 3 years ago • 5 comments

Fixes #477.

kkysen avatar Aug 09 '22 22:08 kkysen

I'm conflicted about having this without also having pre-commit hooks, to avoid only finding out about clippy failures during CI, but I think those two together might be overkill at this stage of the project. So, I think that we should instead have only have commit hooks that the developer may selectively ignore locally rather than make continual exceptions for in CI.

oinoom avatar Aug 24 '22 17:08 oinoom

How do pre-commit hooks work? I would like to use those, especially for cargo fmt.

kkysen avatar Aug 24 '22 18:08 kkysen

https://pre-commit.com/

oinoom avatar Aug 24 '22 18:08 oinoom

https://pre-commit.com/

I'll look into them more, but that seems to be Python-specific pre-commit hooks.

Can pre-commit hooks be pushed to the repo and by default have everyone use them?

kkysen avatar Aug 24 '22 19:08 kkysen

I'll look into them more, but that seems to be Python-specific pre-commit hooks.

Yep, this is just to demonstrate the concept. I'm sure an equivalent for our purposes can be found.

Can pre-commit hooks be pushed to the repo and by default have everyone use them?

That's been my experience in the past, yes

oinoom avatar Aug 24 '22 22:08 oinoom