immich icon indicating copy to clipboard operation
immich copied to clipboard

Sharing from a shared album is blocked if one or more assets not owned by user or partner are selected

Open samholton opened this issue 1 year ago • 3 comments

The bug

In a shared album, if one or more images that are not owned by current user or partner is selected for share, the share operation results in an error:

error

The same is true for the new single asset sharing. The share button could be hidden for single asset share, but how should we address multi-asset selection and sharing from shared album? Do we create the link but remove those without permission? Somehow alert the user which images they are unable to share?

The OS that Immich Server is running on

Debian

Version of Immich Server

v1.97.0

Version of Immich Mobile App

v1.97.0

Platform with the issue

  • [X] Server
  • [X] Web
  • [ ] Mobile

Your docker-compose.yml content

make dev

Your .env content

make dev

Reproduction steps

1. Create shared album
1. Invite user that is not a partner
1. Have each user add images to the shared album
1. Attempt to share from the shared album assets that do not belong to you

Additional information

comment on https://github.com/immich-app/immich/pull/7595

samholton avatar Mar 03 '24 22:03 samholton