immich icon indicating copy to clipboard operation
immich copied to clipboard

Published 20 hours ago • verified publisher icon immich-app

[Feature]: Show album owner

Open oddlama opened this issue 2 years ago • 6 comments

Feature detail

Just a minor thing: When I currently share an album with a person, only the shared persons are shown in the list of people at the top. This is a little confusing for the other users, it appears as if the owner of the album isn't actually added to the album.

image

Two people have access to this album, but it looks like only one person does.

Platform

Web

oddlama avatar Sep 24 '22 18:09 oddlama

Hey, can you assign me this? I am working on it

Spyy004 avatar Oct 12 '22 12:10 Spyy004

can you please tell me the file in the directory which needs inspection?

Spyy004 avatar Oct 17 '22 06:10 Spyy004

@Spyy004 The rendering for the web client's album members is at https://github.com/immich-app/immich/blob/main/web/src/lib/components/album-page/album-viewer.svelte#L420-L438. For the mobile app, it's at https://github.com/immich-app/immich/blob/main/mobile/lib/modules/album/views/album_viewer_page.dart#L158-L184.

bo0tzz avatar Oct 21 '22 12:10 bo0tzz

@Spyy004 are you still working on this, or should I unassign you?

bo0tzz avatar Nov 02 '22 11:11 bo0tzz

If you update the AlbumResponseDTO (or maybe it's now becoming Album) to replaceownerId with a OwnerResponseDTO owner, then I can implement this very easily.

martyfuhry avatar Feb 04 '23 19:02 martyfuhry

We can probably make a change in the api to support this, but I have a feeling owner id isn't currently a foreign key, so it'll take a little bit more effort to do it 😛

jrasm91 avatar Feb 05 '23 02:02 jrasm91