immich icon indicating copy to clipboard operation
immich copied to clipboard

feat(server,web) Semantic import path validation

Open etnoy opened this issue 1 year ago • 5 comments

Check if import paths are valid and warn user if they aren't

  • Does the path exist?
  • Is the path a directory?
  • Do we have read access?

When scanning the library, import paths that do not pass validation are ignored

image

Needs UI polish by a CSS expert like @danieldietzler

etnoy avatar Feb 13 '24 10:02 etnoy

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b93c06
Status: ✅  Deploy successful!
Preview URL: https://87ba4580.immich.pages.dev
Branch Preview URL: https://fix-validate-import-path.immich.pages.dev

View logs

Maybe the warning can go by the path itself not the action buttons

jrasm91 avatar Feb 13 '24 14:02 jrasm91

Maybe the warning can go by the path itself not the action buttons

Yes, the front end stuff needs more work, I'm currently focusing on the backend first

etnoy avatar Feb 13 '24 14:02 etnoy

IMO running the checks separately from changes makes sense. The library can break for external reasons (eg the mount goes offline), in which case having a check that immediately shows that would be nice.

bo0tzz avatar Feb 17 '24 15:02 bo0tzz

Sure, but that should be in addition to doing the check at time of creation imo.

jrasm91 avatar Feb 17 '24 16:02 jrasm91