immich icon indicating copy to clipboard operation
immich copied to clipboard

refactor(mobile): Use hooks to manage Chewie controller for video

Open martyfuhry opened this issue 1 year ago • 4 comments

  • Also changes to using delayed loading throbbers
  • Fixes an issue where videos would not play in immersive mode by default
  • Changes the default hide controls timer to 1.5 seconds to more closely match "the app that shall not be named"
  • Changes the overlay loading to use a delayed loading

This was all to improve the asset video playback experience while navigating the main timeline.

martyfuhry avatar Feb 09 '24 21:02 martyfuhry

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4128d3
Status: ✅  Deploy successful!
Preview URL: https://761938a6.immich.pages.dev
Branch Preview URL: https://fix-video-delayed-loading-th.immich.pages.dev

View logs

When you click on a video, I see that it is immediately in the immersive mode. Tapping on the screen, the control interface shows briefly and returns to the immersive mode. I think this is a bit inconvenient if you want to share a video, because you will have to aim to the middle of the screen to tap and then hit the pause button to get the control interface to show up

alextran1502 avatar Feb 10 '24 05:02 alextran1502

That is definitely a bug. The intended behavior is for the controls to show for the hideControlsTimer duration, but they are hiding immediately. I will fix that, thanks!

martyfuhry avatar Feb 10 '24 11:02 martyfuhry

Rebased and working well on my end here! Ready for another round of review.

martyfuhry avatar Feb 14 '24 23:02 martyfuhry